Open
Conversation
| // so the client can see who participated in the signing. | ||
| const addrDbString = Utils.getAddressNetworkForDbLookup(txp.from || txp.inputs[0]?.address, wallet.network); | ||
| const address = await util.promisify(storage.fetchAddressByWalletId).call(storage, wallet.id, addrDbString); | ||
| const tssSigSeshId = `${txp.id}:${address.path.replace(/\//g, '-')}`; |
Contributor
There was a problem hiding this comment.
I'm generating the session ID on the client like this:
${txp.id}:${derivationPath.replace(/\//g, '-')}-input${i}
Because of that, the fetch always returns null.
Could you update it to:
const tssSigSeshId = `${txp.id}:${address.path.replace(/\//g, '-')}-input1`;
Using -input1 is enough here, I tested it and it works correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Accepted/broadcasted tx proposals for TSS wallets currently only have 1 copayer. This PR adds the other TSS participants as copayers to the txp so the client can see who participated in the TSS signing session.
Changelog
Testing Notes
You should be able to sign a txp with a TSS wallet as usual and the txp should have all signers listed in the copayers array
Checklist